Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevents inactive indicator icon/tooltip from appearing in ActionMenu items #4770

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Prevents inactive indicator icon/tooltip from appearing in ActionMenu items #4770

merged 3 commits into from
Jul 24, 2024

Conversation

mperrotti
Copy link
Contributor

No issue exists for this bug. I think the bug was introduced as the result of a bad merge.

Screenshots

Before:

Kapture.2024-07-23.at.13.51.25.mp4

After:

Kapture.2024-07-23.at.13.53.27.mp4

Changelog

New

Changed

  • Inactive ActionMenu items no longer render a ⚠️ icon w/ the inactive warning message. The warning message is only rendered at the bottom of the ActionMenu item

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

  • For ActionList items: Ensure that the ⚠️ icon still appears and shows a tooltip on hover
  • For ActionMenu and NavList items: Ensure that no ⚠️ icon appears - only warning text at the bottom of the item

Merge checklist

  • [n/a] Added/updated tests
    • This will be caught by visual regression tests
  • [n/a] Added/updated documentation
  • [n/a] Added/updated previews (Storybook)
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge
  • (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

@mperrotti mperrotti requested a review from a team as a code owner July 23, 2024 17:59
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 23, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 8c4fedf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 23, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.48 KB (+0.13% 🔺)
packages/react/dist/browser.umd.js 92.68 KB (-0.01% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-4770 July 23, 2024 18:03 Inactive
broccolinisoup
broccolinisoup approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks for fixing this 🙌🏻

@primer primer bot requested a review from a team as a code owner July 24, 2024 05:09
@primer primer bot requested a review from maximedegreve July 24, 2024 05:09
@broccolinisoup broccolinisoup added this pull request to the merge queue Jul 24, 2024
Merged via the queue into main with commit 8574027 Jul 24, 2024
30 checks passed
@broccolinisoup broccolinisoup deleted the mp/fix-inactive-indicators-in-menus branch July 24, 2024 23:26
@primer primer bot mentioned this pull request Jul 24, 2024
Merged
@LLotme LLotme mentioned this pull request Aug 16, 2024
Merged
@WontonSam WontonSam mentioned this pull request Aug 16, 2024
Open
@OKEAMAH OKEAMAH mentioned this pull request Aug 17, 2024
Merged
@Mapuppy09 Mapuppy09 mentioned this pull request Aug 19, 2024
Merged
@sonukaloshiya sonukaloshiya mentioned this pull request Sep 4, 2024
Open
This was referenced Sep 13, 2024
Open
Open
@AKJUS AKJUS mentioned this pull request Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

@langermank langermank langermank approved these changes

@maximedegreve maximedegreve Awaiting requested review from maximedegreve maximedegreve is a code owner automatically assigned from primer/design-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mperrotti @broccolinisoup @langermank